test: make sure tests fail properly instead of timing out (#24316)

This commit is contained in:
Milan Burda 2020-07-01 00:10:36 +02:00 committed by GitHub
parent 451086d7f2
commit c6db47182a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 1484 additions and 1367 deletions

View file

@ -344,7 +344,7 @@ ifdescribe(features.isRemoteModuleEnabled())('remote module', () => {
});
describe('remote objects registry', () => {
it('does not dereference until the render view is deleted (regression)', (done) => {
it('does not dereference until the render view is deleted (regression)', async () => {
const w = new BrowserWindow({
show: false,
webPreferences: {
@ -353,12 +353,10 @@ ifdescribe(features.isRemoteModuleEnabled())('remote module', () => {
}
});
ipcMain.once('error-message', (event, message) => {
expect(message).to.match(/^Cannot call method 'getURL' on missing remote object/);
done();
});
const message = emittedOnce(ipcMain, 'error-message');
w.loadFile(path.join(fixtures, 'api', 'render-view-deleted.html'));
const [, msg] = await message;
expect(msg).to.match(/^Cannot call method 'getURL' on missing remote object/);
});
});