mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: make sure tests fail properly instead of timing out (#24316)

Browse source
This commit is contained in:
Milan Burda 2020-07-01 00:10:36 +02:00 • committed by GitHub
parent 451086d7f2
commit c6db47182a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 1484 additions and 1367 deletions
Download patch file Download diff file Expand all files Collapse all files

68
spec/api-web-frame-spec.js
View file

@ -39,70 +39,51 @@ describe('webFrame module', function () {
childFrameElement.remove();
});
it('executeJavaScript() yields results via a promise and a sync callback', done => {
it('executeJavaScript() yields results via a promise and a sync callback', async () => {
let callbackResult, callbackError;
childFrame
const executeJavaScript = childFrame
.executeJavaScript('1 + 1', (result, error) => {
callbackResult = result;
callbackError = error;
})
.then(
promiseResult => {
expect(promiseResult).to.equal(2);
done();
},
promiseError => {
done(promiseError);
}
);
});
expect(callbackResult).to.equal(2);
expect(callbackError).to.be.undefined();
const promiseResult = await executeJavaScript;
expect(promiseResult).to.equal(2);
});
it('executeJavaScriptInIsolatedWorld() yields results via a promise and a sync callback', done => {
it('executeJavaScriptInIsolatedWorld() yields results via a promise and a sync callback', async () => {
let callbackResult, callbackError;
childFrame
const executeJavaScriptInIsolatedWorld = childFrame
.executeJavaScriptInIsolatedWorld(999, [{ code: '1 + 1' }], (result, error) => {
callbackResult = result;
callbackError = error;
})
.then(
promiseResult => {
expect(promiseResult).to.equal(2);
done();
},
promiseError => {
done(promiseError);
}
);
});
expect(callbackResult).to.equal(2);
expect(callbackError).to.be.undefined();
const promiseResult = await executeJavaScriptInIsolatedWorld;
expect(promiseResult).to.equal(2);
});
it('executeJavaScript() yields errors via a promise and a sync callback', done => {
it('executeJavaScript() yields errors via a promise and a sync callback', async () => {
let callbackResult, callbackError;
childFrame
const executeJavaScript = childFrame
.executeJavaScript('thisShouldProduceAnError()', (result, error) => {
callbackResult = result;
callbackError = error;
})
.then(
promiseResult => {
done(new Error('error is expected'));
},
promiseError => {
expect(promiseError).to.be.an('error');
done();
}
);
});
expect(callbackResult).to.be.undefined();
expect(callbackError).to.be.an('error');
await expect(executeJavaScript).to.eventually.be.rejected('error is expected');
});
// executeJavaScriptInIsolatedWorld is failing to detect exec errors and is neither
@ -113,23 +94,16 @@ describe('webFrame module', function () {
// it('executeJavaScriptInIsolatedWorld() yields errors via a promise and a sync callback', done => {
// let callbackResult, callbackError
//
// childFrame
// const executeJavaScriptInIsolatedWorld = childFrame
// .executeJavaScriptInIsolatedWorld(999, [{ code: 'thisShouldProduceAnError()' }], (result, error) => {
// callbackResult = result
// callbackError = error
// })
// .then(
// promiseResult => {
// done(new Error('error is expected'))
// },
// promiseError => {
// expect(promiseError).to.be.an('error')
// done()
// }
// )
// });
//
// expect(callbackResult).to.be.undefined()
// expect(callbackError).to.be.an('error')
//
// expect(executeJavaScriptInIsolatedWorld).to.eventually.be.rejected('error is expected');
// })
it('executeJavaScript(InIsolatedWorld) can be used without a callback', async () => {