mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: clean up BrowserView/TopLevelWindow New impl (#19375)

Browse source 
* chore: clean up BrowserView::New impl

* also default TL win options dict
This commit is contained in:
Shelley Vohr 2019-07-26 16:18:13 -07:00 committed by GitHub
parent 5aa1385cfc
commit c6bcf49acc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
shell/browser/api/atom_api_browser_view.cc
View file

@ -102,15 +102,8 @@ mate::WrappableBase* BrowserView::New(mate::Arguments* args) {
return nullptr; return nullptr;
} }
if (args->Length() > 1) { mate::Dictionary options = mate::Dictionary::CreateEmpty(args->isolate());
args->ThrowError("Too many arguments"); args->GetNext(&options);
return nullptr;
}
mate::Dictionary options;
if (!(args->Length() == 1 && args->GetNext(&options))) {
options = mate::Dictionary::CreateEmpty(args->isolate());
}
return new BrowserView(args->isolate(), args->GetThis(), options); return new BrowserView(args->isolate(), args->GetThis(), options);
} }

6
shell/browser/api/atom_api_top_level_window.cc
View file

@ -1030,9 +1030,9 @@ void TopLevelWindow::RemoveFromParentChildWindows() {
// static // static
mate::WrappableBase* TopLevelWindow::New(mate::Arguments* args) { mate::WrappableBase* TopLevelWindow::New(mate::Arguments* args) {
mate::Dictionary options; mate::Dictionary options = mate::Dictionary::CreateEmpty(args->isolate());
if (!(args->Length() == 1 && args->GetNext(&options))) args->GetNext(&options);
options = mate::Dictionary::CreateEmpty(args->isolate());
return new TopLevelWindow(args->isolate(), args->GetThis(), options); return new TopLevelWindow(args->isolate(), args->GetThis(), options);
} }