mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: use more appropriate array methods (#39321)

Browse source
This commit is contained in:
Milan Burda 2023-08-02 19:43:45 +02:00 committed by GitHub
parent 7686d1c379
commit c5e50e4882
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec/api-app-spec.ts
View file

@ -1184,7 +1184,7 @@ describe('app module', () => {
app.setAsDefaultProtocolClient(protocol);
const keys = await promisify(classesKey.keys).call(classesKey) as any[];
const exists = !!keys.find(key => key.key.includes(protocol));
const exists = keys.some(key => key.key.includes(protocol));
expect(exists).to.equal(true);
});
@ -1193,7 +1193,7 @@ describe('app module', () => {
app.removeAsDefaultProtocolClient(protocol);
const keys = await promisify(classesKey.keys).call(classesKey) as any[];
const exists = !!keys.find(key => key.key.includes(protocol));
const exists = keys.some(key => key.key.includes(protocol));
expect(exists).to.equal(false);
});
@ -1209,7 +1209,7 @@ describe('app module', () => {
app.removeAsDefaultProtocolClient(protocol);
const keys = await promisify(classesKey.keys).call(classesKey) as any[];
const exists = !!keys.find(key => key.key.includes(protocol));
const exists = keys.some(key => key.key.includes(protocol));
expect(exists).to.equal(true);
});

2
spec/api-subframe-spec.ts
View file

@ -253,7 +253,7 @@ ifdescribe(process.platform !== 'linux')('cross-site frame sandboxing', () => {
const metrics = app.getAppMetrics();
const isProcessSandboxed = function (pid: number) {
const entry = metrics.filter(metric => metric.pid === pid)[0];
const entry = metrics.find(metric => metric.pid === pid);
return entry && entry.sandboxed;
};

2
spec/lib/video-helpers.js
View file

@ -442,7 +442,7 @@ function parseRIFF (string) {
// basically, the only purpose is for encoding "Duration", which is encoded as
// a double (considerably more difficult to encode than an integer)
function doubleToString (num) {
return [].slice.call(
return Array.prototype.slice.call(
new Uint8Array(
(
new Float64Array([num]) // create a float64 array