fixes from code review

This commit is contained in:
Shelley Vohr 2017-12-11 00:20:26 -05:00
parent 5e51ab9791
commit c5aeda1fdd
No known key found for this signature in database
GPG key ID: F13993A75599653C
3 changed files with 18 additions and 18 deletions

View file

@ -146,13 +146,13 @@ v8::Local<v8::Value> SystemPreferences::GetUserDefault(
void SystemPreferences::RegisterDefaults(mate::Arguments* args) {
base::DictionaryValue value;
if (!args->GetNext(&value)) {
args->ThrowError("Unable to parse userDefaults dict");
return;
}
if (NSDictionary* dict = DictionaryValueToNSDictionary(value)) {
args->GetNext(&value);
@try {
NSDictionary* dict = DictionaryValueToNSDictionary(value);
[[NSUserDefaults standardUserDefaults] registerDefaults:dict];
} @catch (NSException* exception) {
args->ThrowError("Invalid userDefault data provided");
}
}