mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

spec: Test the -able methods

Browse source
This commit is contained in:
Cheng Zhao 2016-01-23 03:35:30 -08:00
parent 010cc3276a
commit c41de501cb
4 changed files with 113 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/native_window.cc
View file

@ -122,7 +122,7 @@ void NativeWindow::InitFromOptions(const mate::Dictionary& options) {
}
#endif
bool movable;
if (options.Get(options::kMovable, &movable) && movable) {
if (options.Get(options::kMovable, &movable)) {
SetMovable(movable);
}
bool has_shadow;

4
atom/browser/native_window_mac.mm
View file

@ -489,9 +489,7 @@ NativeWindowMac::NativeWindowMac(
bool fullscreen = false;
if (options.Get(options::kFullscreen, &fullscreen) && !fullscreen)
fullscreenable = false;
if (!fullscreenable) {
SetFullScreenable(false);
}
SetFullScreenable(fullscreenable);
// Disable zoom button if window is not resizable
if (!maximizable) {

8
atom/browser/native_window_views.cc
View file

@ -465,9 +465,9 @@ void NativeWindowViews::SetMinimizable(bool minimizable) {
bool NativeWindowViews::IsMinimizable() {
#if defined(OS_WIN)
return CanMinimize();
return ::GetWindowLong(GetAcceleratedWidget(), GWL_STYLE) & WS_MINIMIZEBOX;
#else
return true; // CanMinimize() Not implemented on Linux.
return true; // Not implemented on Linux.
#endif
}
@ -480,9 +480,9 @@ void NativeWindowViews::SetMaximizable(bool maximizable) {
bool NativeWindowViews::IsMaximizable() {
#if defined(OS_WIN)
return CanMaximize();
return ::GetWindowLong(GetAcceleratedWidget(), GWL_STYLE) & WS_MAXIMIZEBOX;
#else
return true; // CanMaximize() Not implemented on Linux.
return true; // Not implemented on Linux.
#endif
}