mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Leak IsolateData since Environment is also leaked

Browse source
This commit is contained in:
Kevin Sawicki 2017-01-18 16:41:36 -08:00 • committed by Birunthan Mohanathas
parent 54e2c480cb
commit c374e37cc4
6 changed files with 5 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/renderer/atom_renderer_client.cc
View file

@ -349,13 +349,10 @@ void AtomRendererClient::DidCreateScriptContext(
if (first_time) {
node_bindings_->Initialize();
node_bindings_->PrepareMessageLoop();
isolate_data_.reset(new node::IsolateData(context->GetIsolate(),
uv_default_loop()));
}
// Setup node environment for each window.
node::Environment* env =
node_bindings_->CreateEnvironment(isolate_data_.get(), context);
node::Environment* env = node_bindings_->CreateEnvironment(context);
// Add Electron extended APIs.
atom_bindings_->BindTo(env->isolate(), env->process_object());

5
atom/renderer/atom_renderer_client.h
View file

@ -10,10 +10,6 @@
#include "content/public/renderer/content_renderer_client.h"
namespace node {
class IsolateData;
}
namespace atom {
class AtomBindings;
@ -73,7 +69,6 @@ class AtomRendererClient : public content::ContentRendererClient {
std::unique_ptr<NodeBindings> node_bindings_;
std::unique_ptr<AtomBindings> atom_bindings_;
std::unique_ptr<PreferencesManager> preferences_manager_;
std::unique_ptr<node::IsolateData> isolate_data_;
bool isolated_world_;
DISALLOW_COPY_AND_ASSIGN(AtomRendererClient);