mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Leak IsolateData since Environment is also leaked

Browse source
This commit is contained in:
Kevin Sawicki 2017-01-18 16:41:36 -08:00 • committed by Birunthan Mohanathas
parent 54e2c480cb
commit c374e37cc4
6 changed files with 5 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/common/node_bindings.cc
View file

@ -144,7 +144,7 @@ void NodeBindings::Initialize() {
}
node::Environment* NodeBindings::CreateEnvironment(
node::IsolateData* isolate_data, v8::Handle<v8::Context> context) {
v8::Handle<v8::Context> context) {
auto args = AtomCommandLine::argv();
// Feed node the path to initialization script.
@ -160,7 +160,7 @@ node::Environment* NodeBindings::CreateEnvironment(
std::unique_ptr<const char*[]> c_argv = StringVectorToArgArray(args);
node::Environment* env = node::CreateEnvironment(
isolate_data, context,
new node::IsolateData(context->GetIsolate(), uv_default_loop()), context,
args.size(), c_argv.get(), 0, nullptr);
// Node uses the deprecated SetAutorunMicrotasks(false) mode, we should switch

4
atom/common/node_bindings.h
View file

@ -16,7 +16,6 @@ class MessageLoop;
namespace node {
class Environment;
class IsolateData;
}
namespace atom {
@ -31,8 +30,7 @@ class NodeBindings {
void Initialize();
// Create the environment and load node.js.
node::Environment* CreateEnvironment(node::IsolateData* isolate_data,
v8::Handle<v8::Context> context);
node::Environment* CreateEnvironment(v8::Handle<v8::Context> context);
// Load node.js in the environment.
void LoadEnvironment(node::Environment* env);