Leak IsolateData since Environment is also leaked
This commit is contained in:
parent
54e2c480cb
commit
c374e37cc4
6 changed files with 5 additions and 24 deletions
|
@ -129,13 +129,9 @@ void AtomBrowserMainParts::PostEarlyInitialization() {
|
|||
// Support the "--debug" switch.
|
||||
node_debugger_.reset(new NodeDebugger(js_env_->isolate()));
|
||||
|
||||
isolate_data_.reset(
|
||||
new node::IsolateData(js_env_->isolate(), uv_default_loop()));
|
||||
|
||||
// Create the global environment.
|
||||
node::Environment* env =
|
||||
node_bindings_->CreateEnvironment(isolate_data_.get(),
|
||||
js_env_->context());
|
||||
node_bindings_->CreateEnvironment(js_env_->context());
|
||||
|
||||
// Make sure node can get correct environment when debugging.
|
||||
if (node_debugger_->IsRunning())
|
||||
|
|
|
@ -15,10 +15,6 @@
|
|||
|
||||
class BrowserProcess;
|
||||
|
||||
namespace node {
|
||||
class IsolateData;
|
||||
}
|
||||
|
||||
namespace atom {
|
||||
|
||||
class AtomBindings;
|
||||
|
@ -86,7 +82,6 @@ class AtomBrowserMainParts : public brightray::BrowserMainParts {
|
|||
std::unique_ptr<NodeBindings> node_bindings_;
|
||||
std::unique_ptr<AtomBindings> atom_bindings_;
|
||||
std::unique_ptr<NodeDebugger> node_debugger_;
|
||||
std::unique_ptr<node::IsolateData> isolate_data_;
|
||||
|
||||
base::Timer gc_timer_;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue