mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #4892 from deepak1556/v8_util_patch

Browse source 
common: use v8::private symbols as identifiers for object properties
This commit is contained in:
Cheng Zhao 2016-03-31 10:22:23 +09:00
commit c307478d5d
2 changed files with 31 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/renderer/atom_render_view_observer.cc
View file

@ -39,7 +39,11 @@ bool GetIPCObject(v8::Isolate* isolate,
v8::Local<v8::Context> context,
v8::Local<v8::Object>* ipc) {
v8::Local<v8::String> key = mate::StringToV8(isolate, "ipc");
v8::Local<v8::Value> value = context->Global()->GetHiddenValue(key);
v8::Local<v8::Private> privateKey = v8::Private::ForApi(isolate, key);
v8::Local<v8::Object> global_object = context->Global();
v8::Local<v8::Value> value;
if (!global_object->GetPrivate(context, privateKey).ToLocal(&value))
return false;
if (value.IsEmpty() || !value->IsObject())
return false;
*ipc = value->ToObject();