mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Backport (3-0-x) - Fix devtools not functioning well (#13571)

Browse source 
* implement devtools showItemInFolder message

* add stubs for new devtools messages

* fix: update devtools url

* spec: enable back devtools tests

* spec: disable the i18nString test

It is failed because of fs.statSyncNoException, I'll fix it in another
PR.
This commit is contained in:
trop[bot] 2018-07-06 13:19:21 +10:00 • committed by Samuel Attard
parent 8585372e11
commit c2f4144996
5 changed files with 78 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/api-browser-window-spec.js
View file

@ -2761,8 +2761,7 @@ describe('BrowserWindow module', () => {
})
})
// TODO(alexeykuzmin): [Ch66] Enable the tests.
xdescribe('for a valid extension', () => {
describe('for a valid extension', () => {
const extensionName = 'foo'
const removeExtension = () => {
@ -2803,7 +2802,8 @@ describe('BrowserWindow module', () => {
expect(this.message).to.have.own.property('tabId')
expect(this.message.tabId).to.equal(w.webContents.id)
})
it('has "i18nString" with proper contents', function () {
// TODO(zcbena): [Ch66] Enable the tests.
xit('has "i18nString" with proper contents', function () {
expect(this.message).to.have.own.property('i18nString')
expect(this.message.i18nString).to.equal('foo - bar (baz)')
})
@ -2849,8 +2849,7 @@ describe('BrowserWindow module', () => {
})
})
// TODO(alexeykuzmin): [Ch66] Times out. Fix it and enable.
xit('works when used with partitions', (done) => {
it('works when used with partitions', (done) => {
if (w != null) {
w.destroy()
}