chore: bump chromium to 128.0.6558.0 (32-x-y) (#42746)

* chore: bump chromium to 128.0.6558.0 32-x-y * chore: bump chromium in DEPS to 127.0.6526.0 * chore: update network_service_allow_remote_certificate_verification_logic.patch manually apply patch due to minor upstream shear Xref: 5598454 * chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch No manual changes; patch applied with fuzz 1 * chore: update refactor_expose_file_system_access_blocklist.patch No manual changes; patch applied with fuzz 2 * chore: update revert_heap_add_checks_position_info.patch No manual changes; patch applied with fuzz 1 * chore: e patches all * chore: bump chromium in DEPS to 127.0.6527.0 * chore: update patches * chore: bump chromium in DEPS to 127.0.6529.0 * chore: bump chromium in DEPS to 127.0.6531.0 * chore: update patches * 5596349: Remove PDF OCR toggle from settings. 5596349 * 5585932: [video-pip] Add minimize button to video picture-in-picture window 5585932 * 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real" 5604487 * 5581721: [DEPS] Update clang-format location 5581721 * 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities. 5597904 ResolveNTFunctionPtr was removed in this CL. * fix: visibility state specs on macOS Refs 5605407 * Revert "fix: visibility state specs on macOS" This reverts commit 1eee30a33dfafeec86cdd09526a07b01abca2ed6. * temp: disable occlusion checker on macOS * chore: bump chromium in DEPS to 128.0.6535.0 * chore: update patches * [Extensions] Move some scriptings files out of the API directory. Refs 5606682 * fix[node]: do not use soon-to-be-deprecated V8 API * fix: update api_remove_allcan_read_write.patch * chore: update patches * chore: update patches * chore: fix lf mismatch in api_remove_allcan_read_write.patch * chore: update patches * chore: bump chromium in DEPS to 128.0.6538.0 * chore: update v8 patches * chore: update patches * ui/gl/features.gni: Set use_egl=true unconditionally. Refs 5569748 Refs https://issues.chromium.org/issues/344606399 * chore: bump chromium in DEPS to 128.0.6540.0 * chore: bump chromium in DEPS to 128.0.6541.0 * chore: update patches * chore: fix nan read/write patch * chore: bump chromium in DEPS to 128.0.6543.0 * 5626254: Use sandbox_type instead of process_type | 5626254 * chore: update patches * rework nan patches * 5621488: Apply consistent naming conventions to zoom values | 5621488 * chore: bump chromium in DEPS to 128.0.6544.0 * 5605693: Remove files from third_party/ninja | 5605693 * chore: update patches * chore: maybe fix nan patch, part 3 * chore: delete nan patch * chore: re-add nan patch (attempt 2) * chore: add test patch * fixup! add test patch * chore: bump chromium in DEPS to 128.0.6549.0 * chore: bump chromium in DEPS to 128.0.6551.0 * 5637699: Add command line to ASAN Additional Info section | 5637699 * chore: update patches * chore: bump chromium in DEPS to 128.0.6553.0 * chore: bump chromium in DEPS to 128.0.6555.0 * fix: add property query interceptors * chore: bump chromium in DEPS to 128.0.6557.0 * 5583182: Automatic Fullscreen: Prototype Permissions API query support | 5583182 * 5613297: Move render input router and related dependencies to //components/input | 5613297 * chore: update patches * test: skip methodswithdata-test.js nan test * chore: bump chromium in DEPS to 128.0.6558.0 * chore: update patches * build: reference correct ninja cipd ref Ref: 5605693 * update libcxx filenames * refactor: CursorManager moved to //components/input Ref: 5613297 * refactor: spanify mojo Read/WriteData methods Ref: 5619291 * refactor: remove constexpr from KeyboardCodeFromKeyIdentifier Ref: unknown Added TODO to investigate after * chore: update patches * refactor: improve type safety of a11y ids Ref: 5614590 * chore: disable tls node tests that don't apply given boringssl tls configuration Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487 * chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration Ref: 5630388 * fix: limit subspan length per feedback * Fix incorrect CalculateInsetsInDIP check * 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"" 5645742 * chore: more Windows logging * 5617471: Add NPU blocking to chromium blocklist 5617471 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Alice Zhao <alice@makenotion.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: cleanup .patches after trop --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-03 10:54:21 -04:00 · 2024-07-03 10:54:21 -04:00 · c2939ef9af
commit c2939ef9af
parent 37fc8346aa
122 changed files with 1602 additions and 1178 deletions
--- a/shell/browser/ui/electron_desktop_window_tree_host_linux.cc
+++ b/shell/browser/ui/electron_desktop_window_tree_host_linux.cc
@ -48,7 +48,12 @@ void ElectronDesktopWindowTreeHostLinux::OnWidgetInitDone() {
 gfx::Insets ElectronDesktopWindowTreeHostLinux::CalculateInsetsInDIP(
    ui::PlatformWindowState window_state) const {
  // If we are not showing frame, the insets should be zero.
-  if (!native_window_view_->IsFullscreen()) {
+  if (native_window_view_->IsFullscreen()) {
+    return gfx::Insets();
+  }
+
+  if (!native_window_view_->has_frame() ||
+      !native_window_view_->has_client_frame()) {
    return gfx::Insets();
  }

--- a/shell/browser/ui/inspectable_web_contents.cc
+++ b/shell/browser/ui/inspectable_web_contents.cc
@ -127,15 +127,15 @@ void SetZoomLevelForWebContents(content::WebContents* web_contents,
 }

 double GetNextZoomLevel(double level, bool out) {
-  double factor = blink::PageZoomLevelToZoomFactor(level);
+  double factor = blink::ZoomLevelToZoomFactor(level);
  size_t size = std::size(kPresetZoomFactors);
  for (size_t i = 0; i < size; ++i) {
-    if (!blink::PageZoomValuesEqual(kPresetZoomFactors[i], factor))
+    if (!blink::ZoomValuesEqual(kPresetZoomFactors[i], factor))
      continue;
    if (out && i > 0)
-      return blink::PageZoomFactorToZoomLevel(kPresetZoomFactors[i - 1]);
+      return blink::ZoomFactorToZoomLevel(kPresetZoomFactors[i - 1]);
    if (!out && i != size - 1)
-      return blink::PageZoomFactorToZoomLevel(kPresetZoomFactors[i + 1]);
+      return blink::ZoomFactorToZoomLevel(kPresetZoomFactors[i + 1]);
  }
  return level;
 }
--- a/shell/browser/ui/views/client_frame_view_linux.cc
+++ b/shell/browser/ui/views/client_frame_view_linux.cc
@ -129,12 +129,6 @@ void ClientFrameViewLinux::Init(NativeWindowViews* window,
          window->GetAcceleratedWidget()));
  host_supports_client_frame_shadow_ = tree_host->SupportsClientFrameShadow();

-  bool tiled = tiled_edges().top || tiled_edges().left ||
-               tiled_edges().bottom || tiled_edges().right;
-  frame_provider_ =
-      ui::LinuxUiTheme::GetForProfile(nullptr)->GetWindowFrameProvider(
-          !host_supports_client_frame_shadow_, tiled, frame_->IsMaximized());
-
  UpdateWindowTitle();

  for (auto& button : nav_buttons_) {
@ -150,13 +144,14 @@ void ClientFrameViewLinux::Init(NativeWindowViews* window,
 }

 gfx::Insets ClientFrameViewLinux::GetBorderDecorationInsets() const {
-  const auto insets = frame_provider_->GetFrameThicknessDip();
+  const auto insets = GetFrameProvider()->GetFrameThicknessDip();
+
  // We shouldn't draw frame decorations for the tiled edges.
  // See https://wayland.app/protocols/xdg-shell#xdg_toplevel:enum:state
-  return gfx::Insets::TLBR(tiled_edges().top ? 0 : insets.top(),
-                           tiled_edges().left ? 0 : insets.left(),
-                           tiled_edges().bottom ? 0 : insets.bottom(),
-                           tiled_edges().right ? 0 : insets.right());
+  const auto& edges = tiled_edges();
+  return gfx::Insets::TLBR(
+      edges.top ? 0 : insets.top(), edges.left ? 0 : insets.left(),
+      edges.bottom ? 0 : insets.bottom(), edges.right ? 0 : insets.right());
 }

 gfx::Insets ClientFrameViewLinux::GetInputInsets() const {
@ -244,6 +239,13 @@ int ClientFrameViewLinux::NonClientHitTest(const gfx::Point& point) {
  return FramelessView::NonClientHitTest(point);
 }

+ui::WindowFrameProvider* ClientFrameViewLinux::GetFrameProvider() const {
+  const bool tiled = tiled_edges().top || tiled_edges().left ||
+                     tiled_edges().bottom || tiled_edges().right;
+  return ui::LinuxUiTheme::GetForProfile(nullptr)->GetWindowFrameProvider(
+      !host_supports_client_frame_shadow_, tiled, frame_->IsMaximized());
+}
+
 void ClientFrameViewLinux::GetWindowMask(const gfx::Size& size,
                                         SkPath* window_mask) {
  // Nothing to do here, as transparency is used for decorations, not masks.
@ -284,12 +286,6 @@ void ClientFrameViewLinux::Layout(PassKey) {
    return;
  }

-  bool tiled = tiled_edges().top || tiled_edges().left ||
-               tiled_edges().bottom || tiled_edges().right;
-  frame_provider_ =
-      ui::LinuxUiTheme::GetForProfile(nullptr)->GetWindowFrameProvider(
-          !host_supports_client_frame_shadow_, tiled, frame_->IsMaximized());
-
  UpdateButtonImages();
  LayoutButtons();

@ -303,9 +299,9 @@ void ClientFrameViewLinux::Layout(PassKey) {

 void ClientFrameViewLinux::OnPaint(gfx::Canvas* canvas) {
  if (!frame_->IsFullscreen()) {
-    frame_provider_->PaintWindowFrame(canvas, GetLocalBounds(),
-                                      GetTitlebarBounds().bottom(),
-                                      ShouldPaintAsActive(), GetInputInsets());
+    GetFrameProvider()->PaintWindowFrame(
+        canvas, GetLocalBounds(), GetTitlebarBounds().bottom(),
+        ShouldPaintAsActive(), GetInputInsets());
  }
 }

@ -336,7 +332,8 @@ void ClientFrameViewLinux::UpdateThemeValues() {
    gtk_style_context_set_state(button_context, GTK_STATE_FLAG_BACKDROP);
  }

-  theme_values_.window_border_radius = frame_provider_->GetTopCornerRadiusDip();
+  theme_values_.window_border_radius =
+      GetFrameProvider()->GetTopCornerRadiusDip();

  gtk::GtkStyleContextGet(headerbar_context, "min-height",
                          &theme_values_.titlebar_min_height, nullptr);
--- a/shell/browser/ui/views/client_frame_view_linux.h
+++ b/shell/browser/ui/views/client_frame_view_linux.h
@ -78,9 +78,11 @@ class ClientFrameViewLinux : public FramelessView,
  void Layout(PassKey) override;
  void OnPaint(gfx::Canvas* canvas) override;

-  // Overriden from views::ViewTargeterDelegate
+  // Overridden from views::ViewTargeterDelegate
  views::View* TargetForRect(views::View* root, const gfx::Rect& rect) override;

+  ui::WindowFrameProvider* GetFrameProvider() const;
+
 private:
  static constexpr int kNavButtonCount = 4;

@ -137,8 +139,6 @@ class ClientFrameViewLinux : public FramelessView,

  bool host_supports_client_frame_shadow_ = false;

-  raw_ptr<ui::WindowFrameProvider> frame_provider_;
-
  base::ScopedObservation<ui::NativeTheme, ui::NativeThemeObserver>
      native_theme_observer_{this};
  base::ScopedObservation<ui::LinuxUi, ui::WindowButtonOrderObserver>
--- a/shell/browser/ui/webui/accessibility_ui.cc
+++ b/shell/browser/ui/webui/accessibility_ui.cc
@ -161,7 +161,7 @@ base::Value::Dict BuildTargetDescriptor(views::Widget* widget) {
  widget_data.Set(kTypeField, kWidget);

  // Use the Widget's root view ViewAccessibility's unique ID for lookup.
-  int id = widget->GetRootView()->GetViewAccessibility().GetUniqueId().Get();
+  int32_t id = widget->GetRootView()->GetViewAccessibility().GetUniqueId();
  widget_data.Set(kWidgetIdField, id);
  return widget_data;
 }