Set appropriate defaults for webview options (#12271)

* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values

* Test inherited default propogation

* Refactor to remove coupling from fetching values and defaults

* Test description type

* Fix up tests
This commit is contained in:
Charles Kerr 2018-03-15 13:56:46 +09:00 committed by Samuel Attard
parent f54c94d6c9
commit c2673aa970
11 changed files with 110 additions and 11 deletions

View file

@ -2999,7 +2999,7 @@ describe('BrowserWindow module', () => {
})
it('enables context isolation on child windows', (done) => {
app.once('browser-window-created', (event, window) => {
assert.equal(window.webContents.getWebPreferences().contextIsolation, true)
assert.equal(window.webContents.getLastWebPreferences().contextIsolation, true)
done()
})
w.loadURL(`file://${fixtures}/pages/window-open.html`)