mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: add EmitDeprecationWarning helper (#46879)

Browse source 
* refactor: add EmitDeprecationWarning helper

Also switches EmitWarning to using Node's ProcessEmitWarningGeneric

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

* chore: use node namespace for function call

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
This commit is contained in:
trop[bot] 2025-05-01 09:44:59 -05:00 • committed by GitHub
parent ee65ab75f5
commit c24f330b45
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 34 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/browser/api/electron_api_web_request.cc
View file

@ -666,10 +666,9 @@ void WebRequest::SetListener(Event event,
}
if (filter_include_patterns.empty()) {
util::EmitWarning(
util::EmitDeprecationWarning(
"The urls array in WebRequestFilter is empty, which is deprecated. "
"Please use '<all_urls>' to match all URLs.",
"DeprecationWarning");
"Please use '<all_urls>' to match all URLs.");
filter_include_patterns.insert("<all_urls>");
}

5
shell/browser/native_window_mac.mm
View file

@ -182,9 +182,8 @@ NativeWindowMac::NativeWindowMac(const gin_helper::Dictionary& options,
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
if (windowType == "textured" && (transparent() || !has_frame())) {
util::EmitWarning(
"The 'textured' window type is deprecated and will be removed",
"DeprecationWarning");
util::EmitDeprecationWarning(
"The 'textured' window type is deprecated and will be removed");
styleMask |= NSWindowStyleMaskTexturedBackground;
}
#pragma clang diagnostic pop