mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Write a warning instead of crashing.

Browse source
This commit is contained in:
Charlie Hess 2017-01-13 12:28:11 -08:00 • committed by Kevin Sawicki
parent bc2f1e8199
commit c213971a2d
3 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec/api-ipc-spec.js
View file

@ -495,7 +495,7 @@ describe('ipc module', function () {
assert.equal(w.listenerCount('test'), 0)
})
it('throws an error when a function is called in a destroyed renderer', (done) => {
it('shows a warning when a function is called in a destroyed renderer', (done) => {
w = new BrowserWindow({
show: false
})
@ -506,8 +506,8 @@ describe('ipc module', function () {
'Function provided here: remote-event-handler.html:11:33',
'Remote event names: remote-handler, other-remote-handler'
].join('\n')
const errorMessage = ipcRenderer.sendSync('try-emit-web-contents-event', w.webContents.id, 'remote-handler')
assert.equal(errorMessage, expectedMessage)
const warningMessage = ipcRenderer.sendSync('try-emit-web-contents-event', w.webContents.id, 'remote-handler')
assert.equal(warningMessage, expectedMessage)
done()
})
w.webContents.reload()