mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #11256 from electron/fix-11244

Browse source 
Enable "<webview> tag found-in-page event emits when a request is made"
This commit is contained in:
Zeke Sikelianos 2017-11-30 10:48:00 -08:00 • committed by GitHub
commit c1728720a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
spec/webview-spec.js
View file

@ -936,9 +936,7 @@ describe('<webview> tag', function () {
}) })
}) })
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade. describe('found-in-page event', () => {
// Fix it and enable.
xdescribe('found-in-page event', () => {
it('emits when a request is made', (done) => { it('emits when a request is made', (done) => {
let requestId = null let requestId = null
let activeMatchOrdinal = [] let activeMatchOrdinal = []
@ -961,6 +959,11 @@ describe('<webview> tag', function () {
webview.addEventListener('did-finish-load', listener2) webview.addEventListener('did-finish-load', listener2)
webview.src = `file://${fixtures}/pages/content.html` webview.src = `file://${fixtures}/pages/content.html`
document.body.appendChild(webview) document.body.appendChild(webview)
// TODO(deepak1556): With https://codereview.chromium.org/2836973002
// focus of the webContents is required when triggering the api.
// Remove this workaround after determining the cause for
// incorrect focus.
webview.focus()
}) })
}) })