mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Do not create duplicate V8Platform in NodeDebugger

Browse source
This commit is contained in:
Cheng Zhao 2017-12-08 09:31:35 +09:00
parent 00afeaba9a
commit c0c2461245
5 changed files with 7 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

15
atom/browser/node_debugger.cc
View file

@ -14,15 +14,13 @@
namespace atom {
NodeDebugger::NodeDebugger(node::Environment* env)
: env_(env), platform_(nullptr) {
: env_(env) {
}
NodeDebugger::~NodeDebugger() {
if (platform_)
FreePlatform(platform_);
}
void NodeDebugger::Start() {
void NodeDebugger::Start(node::NodePlatform* platform) {
auto inspector = env_->inspector_agent();
if (inspector == nullptr)
return;
@ -37,13 +35,6 @@ void NodeDebugger::Start() {
}
if (options.inspector_enabled()) {
// Use custom platform since the gin platform does not work correctly
// with node's inspector agent. We use the default thread pool size
// specified by node.cc
platform_ = node::CreatePlatform(
/* thread_pool_size */ 4, env_->event_loop(),
/* tracing_controller */ nullptr);
// Set process._debugWaitConnect if --inspect-brk was specified to stop
// the debugger on the first line
if (options.wait_for_connect()) {
@ -51,7 +42,7 @@ void NodeDebugger::Start() {
process.Set("_breakFirstLine", true);
}
inspector->Start(platform_, nullptr, options);
inspector->Start(platform, nullptr, options);
}
}