mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

AtomBindings should not use default uv loop

Browse source
This commit is contained in:
Cheng Zhao 2017-03-10 17:07:51 +09:00
parent 9c9c8ec5f1
commit c068285ff8
7 changed files with 14 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/renderer/atom_renderer_client.cc
View file

@ -217,7 +217,7 @@ std::vector<std::string> ParseSchemesCLISwitch(const char* switch_name) {
AtomRendererClient::AtomRendererClient()
: node_integration_initialized_(false),
node_bindings_(NodeBindings::Create(NodeBindings::RENDERER)),
atom_bindings_(new AtomBindings) {
atom_bindings_(new AtomBindings(uv_default_loop())) {
isolated_world_ = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kContextIsolation);
// Parse --standard-schemes=scheme1,scheme2

4
atom/renderer/web_worker_observer.cc
View file

@ -29,7 +29,7 @@ WebWorkerObserver* WebWorkerObserver::GetCurrent() {
WebWorkerObserver::WebWorkerObserver()
: node_bindings_(NodeBindings::Create(NodeBindings::WORKER)),
atom_bindings_(new AtomBindings) {
atom_bindings_(new AtomBindings(node_bindings_->uv_loop())) {
lazy_tls.Pointer()->Set(this);
}
@ -66,8 +66,6 @@ void WebWorkerObserver::ContextWillDestroy(v8::Local<v8::Context> context) {
// Destroy the node environment.
node::FreeEnvironment(env);
atom_bindings_.reset();
node_bindings_.reset();
delete this;
}