From bff298987f45089e95e54b97463261db0b0cfd70 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Mon, 12 Aug 2024 02:55:54 -0500 Subject: [PATCH] chore: remove unused Notification fields icon_path_, has_icon_ (#43286) Last use of `icon_path_` was removed on May 29, 2017 (c741b584) Last use of `has_icon_` was removed on May 30, 2017 (5048425e) --- shell/browser/api/electron_api_notification.cc | 5 +---- shell/browser/api/electron_api_notification.h | 2 -- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/shell/browser/api/electron_api_notification.cc b/shell/browser/api/electron_api_notification.cc index e78da69df927..999f55b39ddd 100644 --- a/shell/browser/api/electron_api_notification.cc +++ b/shell/browser/api/electron_api_notification.cc @@ -58,10 +58,7 @@ Notification::Notification(gin::Arguments* args) { opts.Get("title", &title_); opts.Get("subtitle", &subtitle_); opts.Get("body", &body_); - has_icon_ = opts.Get("icon", &icon_); - if (has_icon_) { - opts.Get("icon", &icon_path_); - } + opts.Get("icon", &icon_); opts.Get("silent", &silent_); opts.Get("replyPlaceholder", &reply_placeholder_); opts.Get("urgency", &urgency_); diff --git a/shell/browser/api/electron_api_notification.h b/shell/browser/api/electron_api_notification.h index 0ba10e8c7998..7cdf6cba5d53 100644 --- a/shell/browser/api/electron_api_notification.h +++ b/shell/browser/api/electron_api_notification.h @@ -103,8 +103,6 @@ class Notification : public gin::Wrappable, std::u16string subtitle_; std::u16string body_; gfx::Image icon_; - std::u16string icon_path_; - bool has_icon_ = false; bool silent_ = false; bool has_reply_ = false; std::u16string timeout_type_;