mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: use white background for non-OSR renderer by default (#14934)

Browse source
This commit is contained in:
Cheng Zhao 2018-10-03 13:41:37 +09:00 committed by GitHub
parent ee6de82c08
commit bf928ee443
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
atom/browser/web_contents_preferences.cc
View file

@ -213,8 +213,13 @@ void WebContentsPreferences::AppendCommandLineSwitches(
// --background-color. // --background-color.
std::string s; std::string s;
if (dict_.GetString(options::kBackgroundColor, &s)) if (dict_.GetString(options::kBackgroundColor, &s)) {
command_line->AppendSwitchASCII(switches::kBackgroundColor, s); command_line->AppendSwitchASCII(switches::kBackgroundColor, s);
} else if (!(dict_.GetBoolean(options::kOffscreen, &b) && b)) {
// For non-OSR WebContents, we expect to have white background, see
// https://github.com/electron/electron/issues/13764 for more.
command_line->AppendSwitchASCII(switches::kBackgroundColor, "#fff");
}
// --guest-instance-id, which is used to identify guest WebContents. // --guest-instance-id, which is used to identify guest WebContents.
int guest_instance_id = 0; int guest_instance_id = 0;