mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix styling and add spec

Browse source
This commit is contained in:
Shelley Vohr 2018-02-28 00:22:42 -08:00
commit bf491de9fe
No known key found for this signature in database
GPG key ID: F13993A75599653C
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/atom_api_browser_window.cc
View file

@ -1086,7 +1086,7 @@ void BrowserWindow::AddTabbedWindow(NativeWindow* window,
mate::Arguments* args) {
const bool windowAdded = window_->AddTabbedWindow(window);
if (!windowAdded)
args->ThrowError("AddTabbedWindow cannot be called by a window on itself");
args->ThrowError("AddTabbedWindow cannot be called by a window on itself.");
}
void BrowserWindow::SetVibrancy(mate::Arguments* args) {

1
atom/browser/native_window_mac.mm
View file

@ -918,7 +918,6 @@ NativeWindowMac::NativeWindowMac(
}
if (transparent()) {
NSLog(@"Setting transparent");
// Setting the background color to clear will also hide the shadow.
[window_ setBackgroundColor:[NSColor clearColor]];
}

6
spec/api-browser-window-spec.js
View file

@ -733,6 +733,12 @@ describe('BrowserWindow module', () => {
done()
})
})
it('throws when called on itself', () => {
assert.throws(() => {
w.addTabbedWindow(w)
}, /AddTabbedWindow cannot be called by a window on itself./)
})
})
describe('BrowserWindow.setVibrancy(type)', () => {