mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

shell: return status for moveItemToTrash on all platforms

Browse source
This commit is contained in:
Robo 2015-03-27 18:31:57 +05:30
parent 8aae7c4440
commit bedea89dcf
5 changed files with 38 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

17
atom/common/platform_util_linux.cc
View file

@ -13,7 +13,7 @@
namespace {
void XDGUtil(const std::string& util, const std::string& arg) {
bool XDGUtil(const std::string& util, const std::string& arg) {
std::vector<std::string> argv;
argv.push_back(util);
argv.push_back(arg);
@ -27,8 +27,15 @@ void XDGUtil(const std::string& util, const std::string& arg) {
options.environ["MM_NOTTTY"] = "1";
base::ProcessHandle handle;
if (base::LaunchProcess(argv, options, &handle))
base::EnsureProcessGetsReaped(handle);
if (base::LaunchProcess(argv, options, &handle)) {
int exit_code;
base::Process process(handle);
base::EnsureProcessGetsReaped(handle);
process.WaitForExit(&exit_code);
return (exit_code == 0);
}
return false;
}
void XDGOpen(const std::string& path) {
@ -65,8 +72,8 @@ void OpenExternal(const GURL& url) {
XDGOpen(url.spec());
}
void MoveItemToTrash(const base::FilePath& full_path) {
XDGUtil("gvfs-trash", full_path.value());
bool MoveItemToTrash(const base::FilePath& full_path) {
return XDGUtil("gvfs-trash", full_path.value());
}
void Beep() {