mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: reply notifs sometimes destroyed too early (#25086)

Browse source 
* fix: reply notifs sometimes destroyed too early

* Fix windows build
This commit is contained in:
Shelley Vohr 2020-08-23 21:27:46 -07:00 • committed by GitHub
parent a23c66e4e1
commit bea6c9e4e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/notifications/notification.cc
View file

@ -21,10 +21,12 @@ Notification::~Notification() {
delegate()->NotificationDestroyed();
}
void Notification::NotificationClicked() {
void Notification::NotificationClicked(bool should_destroy) {
if (delegate())
delegate()->NotificationClick();
Destroy();
if (should_destroy)
Destroy();
}
void Notification::NotificationDismissed() {