From be8f9bd597392f37d08d46f38f5152b8c01fa868 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 26 Feb 2019 08:51:29 +0000 Subject: [PATCH] chore: clean up issue templates (#17085) * chore: clean up issue templates * address feedback from review * cleanup --- .github/ISSUE_TEMPLATE/Bug_report.md | 14 +++++++------- .github/ISSUE_TEMPLATE/Feature_request.md | 16 ++++++++-------- .../mac-app-store-private-api-rejection.md | 13 ------------- .../mac_app_store_private_api_rejection.md | 14 ++++++++++++++ .../{security-report.md => security_report.md} | 5 +++-- .github/PULL_REQUEST_TEMPLATE.md | 1 - 6 files changed, 32 insertions(+), 31 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/mac-app-store-private-api-rejection.md create mode 100644 .github/ISSUE_TEMPLATE/mac_app_store_private_api_rejection.md rename .github/ISSUE_TEMPLATE/{security-report.md => security_report.md} (53%) diff --git a/.github/ISSUE_TEMPLATE/Bug_report.md b/.github/ISSUE_TEMPLATE/Bug_report.md index e178aa66a44c..640407e92248 100644 --- a/.github/ISSUE_TEMPLATE/Bug_report.md +++ b/.github/ISSUE_TEMPLATE/Bug_report.md @@ -4,17 +4,17 @@ about: Create a report to help us improve Electron --- -* **Electron Version** (output of `node_modules/.bin/electron --version`): - * -* **Operating System** (Platform and Version): - * -* **Last known working Electron version** (if applicable): - * +* **Electron Version:** + * +* **Operating System:** + * +* **Last Known Working Electron version:**: + * ### Expected Behavior -### Actual behavior +### Actual Behavior ### To Reproduce diff --git a/.github/ISSUE_TEMPLATE/Feature_request.md b/.github/ISSUE_TEMPLATE/Feature_request.md index 51c2e6c8d52c..0d494f80b763 100644 --- a/.github/ISSUE_TEMPLATE/Feature_request.md +++ b/.github/ISSUE_TEMPLATE/Feature_request.md @@ -4,14 +4,14 @@ about: Suggest an idea for Electron --- -**Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. +### Problem Description + -**Describe the solution you'd like** -A clear and concise description of what you want to happen. +### Proposed Solution + -**Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. +### Alternatives Considered + -**Additional context** -Add any other context or screenshots about the feature request here. +### Additional Information + diff --git a/.github/ISSUE_TEMPLATE/mac-app-store-private-api-rejection.md b/.github/ISSUE_TEMPLATE/mac-app-store-private-api-rejection.md deleted file mode 100644 index 32939a4e597f..000000000000 --- a/.github/ISSUE_TEMPLATE/mac-app-store-private-api-rejection.md +++ /dev/null @@ -1,13 +0,0 @@ ---- -name: Mac App Store Private API Rejection -about: Your app was rejected from the Mac App Store for using private API's - ---- - -* Electron Version: - -**Rejection Email** -Paste the contents of your rejection email here, censoring any private information such as app names. - -**Additional Information** -Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/mac_app_store_private_api_rejection.md b/.github/ISSUE_TEMPLATE/mac_app_store_private_api_rejection.md new file mode 100644 index 000000000000..b391a5e2826e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/mac_app_store_private_api_rejection.md @@ -0,0 +1,14 @@ +--- +name: Mac App Store Private API Rejection +about: Your app was rejected from the Mac App Store for using private API's + +--- + +* **Electron Version:** + * + +### Rejection Email + + +### Additional Information + diff --git a/.github/ISSUE_TEMPLATE/security-report.md b/.github/ISSUE_TEMPLATE/security_report.md similarity index 53% rename from .github/ISSUE_TEMPLATE/security-report.md rename to .github/ISSUE_TEMPLATE/security_report.md index edb57a981a97..8c2498da2e2b 100644 --- a/.github/ISSUE_TEMPLATE/security-report.md +++ b/.github/ISSUE_TEMPLATE/security_report.md @@ -4,6 +4,7 @@ about: Do not create an issue for security reports, send an email to security@el --- -Do not create an issue for security reports, send an email to: +### Notice -security@electronjs.org +**DO NOT** create an issue for security reports. +Send an email to: **security@electronjs.org**. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f99ab060bd0b..e8215e0dc534 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,7 +16,6 @@ Contributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTIN - [ ] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines) - [ ] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples). - #### Release Notes Notes: