mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix throwing error in constructor

Browse source
This commit is contained in:
Cheng Zhao 2015-01-02 18:04:46 -08:00
parent 4a1d11b2be
commit be2934d9b5
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
native_mate/constructor.h
View file

@ -159,6 +159,8 @@ class Constructor {
Wrappable* object = internal::InvokeFactory(args, factory); Wrappable* object = internal::InvokeFactory(args, factory);
if (object) if (object)
object->Wrap(isolate, args->GetThis()); object->Wrap(isolate, args->GetThis());
else
args->ThrowError();
MATE_METHOD_RETURN_UNDEFINED(); MATE_METHOD_RETURN_UNDEFINED();
} }

5
native_mate/constructor.h.pump
View file

@ -87,6 +87,11 @@ class Constructor {
private: private:
static MATE_METHOD_RETURN_TYPE New(const WrappableFactoryFunction& factory, static MATE_METHOD_RETURN_TYPE New(const WrappableFactoryFunction& factory,
v8::Isolate* isolate, Arguments* args) { v8::Isolate* isolate, Arguments* args) {
if (!args->IsConstructCall()) {
args->ThrowError("Requires constructor call");
MATE_METHOD_RETURN_UNDEFINED();
}
Wrappable* object = internal::InvokeFactory(args, factory); Wrappable* object = internal::InvokeFactory(args, factory);
if (object) if (object)
object->Wrap(isolate, args->GetThis()); object->Wrap(isolate, args->GetThis());