mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: Linux visibleOnAllWorkspaces property (#46861)

Browse source 
* test: do not skip visibleOnAllWorkspaces tests on Windows

That feature is supported on Linux, so move the test from the
"window states (excluding Linux)" section into the
"window states" section.

Co-authored-by: Charles Kerr <charles@charleskerr.com>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>

* chore: disable visibleOnAllWorkspaces test on Linux

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: NativeWindowViews::IsVisibleOnAllWorkspaces

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* test: enable visibleOnAllWorkspaces tests on Linux

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-04-30 10:50:23 -05:00 • committed by GitHub
commit bdde668926
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
spec/api-browser-window-spec.ts
View file

@ -5407,8 +5407,7 @@ describe('BrowserWindow module', () => {
});
});
// FIXME: enable this test on Linux as well.
ifdescribe(process.platform === 'darwin')('visibleOnAllWorkspaces state', () => {
ifdescribe(process.platform !== 'win32')('visibleOnAllWorkspaces state', () => {
describe('with properties', () => {
it('can be changed', () => {
const w = new BrowserWindow({ show: false });