fix: enable spell checking, which broke in upgrade to ch66

Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes #13608.

[1]: 03563dd163
This commit is contained in:
Jeremy Apthorp 2018-07-10 12:43:39 -07:00
parent 6fbec9d5a9
commit bdceea6aca
4 changed files with 38 additions and 0 deletions

View file

@ -1,8 +1,14 @@
const assert = require('assert')
const chai = require('chai')
const dirtyChai = require('dirty-chai')
const path = require('path')
const {closeWindow} = require('./window-helpers')
const {remote, webFrame} = require('electron')
const {BrowserWindow, protocol, ipcMain} = remote
const {emittedOnce} = require('./events-helpers')
const {expect} = chai
chai.use(dirtyChai)
/* Most of the APIs here don't use standard callbacks */
/* eslint-disable standard/no-callback-literal */
@ -138,4 +144,18 @@ describe('webFrame module', function () {
webFrame.setLayoutZoomLevelLimits(0, 25)
})
})
it('calls a spellcheck provider', async () => {
w = new BrowserWindow({show: false})
w.loadURL(`file://${fixtures}/pages/webframe-spell-check.html`)
await emittedOnce(w.webContents, 'did-finish-load')
const spellCheckerFeedback = emittedOnce(ipcMain, 'spec-spell-check')
const misspelledWord = 'spleling'
for (const keyCode of [...misspelledWord, ' ']) {
w.webContents.sendInputEvent({type: 'char', keyCode})
}
const [, text] = await spellCheckerFeedback
expect(text).to.equal(misspelledWord)
})
})