mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fixing code review issues: adding some test cases for partition/session options.

Browse source
This commit is contained in:
ali.ibrahim 2016-10-25 16:19:26 +02:00
parent b44d5290e2
commit bdb3f4d4cb
4 changed files with 91 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/browser/api/net.js
View file

@ -5,7 +5,7 @@ const {EventEmitter} = require('events')
const util = require('util')
const {Readable} = require('stream')
const {app} = require('electron')
const {session} = require('electron')
const {Session} = process.atomBinding('session')
const {net, Net} = process.atomBinding('net')
const {URLRequest} = net
@ -161,7 +161,7 @@ class ClientRequest extends EventEmitter {
url: urlStr
}
if (options.session) {
if (options.session instanceof session.Session) {
if (options.session instanceof Session) {
urlRequestOptions.session = options.session
} else {
throw new TypeError('`session` should be an instance of the Session class.')