mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fixing code review issues: adding some test cases for partition/session options.

Browse source
This commit is contained in:
ali.ibrahim 2016-10-25 16:19:26 +02:00
parent b44d5290e2
commit bdb3f4d4cb
4 changed files with 91 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
atom/browser/api/atom_api_url_request.h
View file

@ -86,9 +86,10 @@ namespace api {
// more complex.
//
// We chose to split the implementation into two classes linked via a
// strong/weak pointers. A URLRequest instance is deleted if it is unpinned and
// the corresponding JS wrapper object is garbage collected. On the other hand,
// an AtmURLRequest instance lifetime is totally governed by reference counting.
// reference counted/raw pointers. A URLRequest instance is deleted if it is
// unpinned and the corresponding JS wrapper object is garbage collected. On the
// other hand, an AtmURLRequest instance lifetime is totally governed by
// reference counting.
//
class URLRequest : public mate::EventEmitter<URLRequest> {
public:
@ -179,16 +180,6 @@ class URLRequest : public mate::EventEmitter<URLRequest> {
uint32_t ResponseHttpVersionMajor() const;
uint32_t ResponseHttpVersionMinor() const;
// template <typename... ArgTypes>
// std::array<v8::Local<v8::Value>, sizeof...(ArgTypes)> BuildArgsArray(
// ArgTypes... args) const;
// template <typename... ArgTypes>
// void EmitRequestEvent(ArgTypes... args);
// template <typename... ArgTypes>
// void EmitResponseEvent(ArgTypes... args);
void Close();
void Pin();
void Unpin();