From 28100a8695e3f683d7efb873f8dae4706ce54b6f Mon Sep 17 00:00:00 2001 From: Jordan Piepkow Date: Tue, 23 May 2017 15:26:22 -0400 Subject: [PATCH 1/3] added force option in electron-download. Downloading from cache causes a checksum check that causes some builds to fail(see https://github.com/electron/electron/issues/8653) that that rely on stable electron releases(pre electron v1.7.0 beta) where chromedrive is not named based on electron version. This will add the option to always force a redownload. --- npm/install.js | 1 + 1 file changed, 1 insertion(+) diff --git a/npm/install.js b/npm/install.js index 7ffc429a0bf1..f49189d4c3d1 100755 --- a/npm/install.js +++ b/npm/install.js @@ -29,6 +29,7 @@ download({ platform: process.env.npm_config_platform, arch: process.env.npm_config_arch, strictSSL: process.env.npm_config_strict_ssl === 'true', + force: process.env.force_no_cache || false, quiet: ['info', 'verbose', 'silly', 'http'].indexOf(process.env.npm_config_loglevel) === -1 }, extractFile) From ffc22ef926c623efd8f3f29c5d3e0daf0010b482 Mon Sep 17 00:00:00 2001 From: Jordan Piepkow Date: Tue, 23 May 2017 16:16:01 -0400 Subject: [PATCH 2/3] switched to the more standard approach in this file Switched to defaulting back to string 'false' as that is how it was already doing strictSSL and electron-download treats and checks both against bools so would make sense to keep it the same across the document. --- npm/install.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/npm/install.js b/npm/install.js index f49189d4c3d1..3a93295f35db 100755 --- a/npm/install.js +++ b/npm/install.js @@ -29,7 +29,7 @@ download({ platform: process.env.npm_config_platform, arch: process.env.npm_config_arch, strictSSL: process.env.npm_config_strict_ssl === 'true', - force: process.env.force_no_cache || false, + force: process.env.force_no_cache === 'true', quiet: ['info', 'verbose', 'silly', 'http'].indexOf(process.env.npm_config_loglevel) === -1 }, extractFile) From 063df812310a46a3a7ec96ebc86f897070f645f2 Mon Sep 17 00:00:00 2001 From: Jordan Piepkow Date: Thu, 1 Jun 2017 14:30:39 -0400 Subject: [PATCH 3/3] Update README.md --- npm/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/npm/README.md b/npm/README.md index f9c079b55dad..c82de731daf6 100644 --- a/npm/README.md +++ b/npm/README.md @@ -59,6 +59,8 @@ If you want to change the architecture that is downloaded (e.g., `ia32` on an npm install --arch=ia32 electron ``` +If you need to force a re-download of the asset and the SHASUM file set the `force_no_cache` enviroment variable to true. + ## About Works on Mac, Windows and Linux OSes that Electron supports (e.g. Electron