fix: properly generate requestID in webContents.printToPDF() (#20769)

This commit is contained in:
Milan Burda 2019-10-29 03:36:29 +01:00 committed by Cheng Zhao
parent b6246dcf12
commit bd5a5b3ae6
2 changed files with 17 additions and 2 deletions

View file

@ -1400,6 +1400,19 @@ describe('webContents module', () => {
const data = await w.webContents.printToPDF({})
expect(data).to.be.an.instanceof(Buffer).that.is.not.empty()
})
it('does not crash when called multiple times', async () => {
const w = new BrowserWindow({ show: false, webPreferences: { sandbox: true } })
await w.loadURL('data:text/html,<h1>Hello, World!</h1>')
const promises = []
for (let i = 0; i < 2; i++) {
promises.push(w.webContents.printToPDF({}))
}
const results = await Promise.all(promises)
for (const data of results) {
expect(data).to.be.an.instanceof(Buffer).that.is.not.empty()
}
})
})
describe('PictureInPicture video', () => {