mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use GetDefaultStoragePartition() instead of GetStoragePartition(nullptr) (#46083)

Browse source 
refactor: use GetDefaultStoragePartition()

Use GetDefaultStorageParition() instead of GetStoragePartition(nullptr)

- It improves code uniformity, since we use get-default everywhere else
- It's more readable
- It's marginally faster, since GetStoragePartition() has more steps

Added in 49b0a1bf4a

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-03-17 19:43:52 +01:00 • committed by GitHub
parent 9716b6623e
commit bc9389df9a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/api/electron_api_session.cc
View file

@ -701,14 +701,13 @@ v8::Local<v8::Promise> Session::ClearStorageData(gin::Arguments* args) {
ClearStorageDataOptions options; ClearStorageDataOptions options;
args->GetNext(&options); args->GetNext(&options);
auto* storage_partition = browser_context()->GetStoragePartition(nullptr);
if (options.storage_types & StoragePartition::REMOVE_DATA_MASK_COOKIES) { if (options.storage_types & StoragePartition::REMOVE_DATA_MASK_COOKIES) {
// Reset media device id salt when cookies are cleared. // Reset media device id salt when cookies are cleared.
// https://w3c.github.io/mediacapture-main/#dom-mediadeviceinfo-deviceid // https://w3c.github.io/mediacapture-main/#dom-mediadeviceinfo-deviceid
MediaDeviceIDSalt::Reset(browser_context()->prefs()); MediaDeviceIDSalt::Reset(browser_context()->prefs());
} }
storage_partition->ClearData( browser_context()->GetDefaultStoragePartition()->ClearData(
options.storage_types, options.quota_types, options.storage_key, options.storage_types, options.quota_types, options.storage_key,
base::Time(), base::Time::Max(), base::Time(), base::Time::Max(),
base::BindOnce(gin_helper::Promise<void>::ResolvePromise, base::BindOnce(gin_helper::Promise<void>::ResolvePromise,
@ -717,8 +716,7 @@ v8::Local<v8::Promise> Session::ClearStorageData(gin::Arguments* args) {
} }
void Session::FlushStorageData() { void Session::FlushStorageData() {
auto* storage_partition = browser_context()->GetStoragePartition(nullptr); browser_context()->GetDefaultStoragePartition()->Flush();
storage_partition->Flush();
} }
v8::Local<v8::Promise> Session::SetProxy(gin::Arguments* args) { v8::Local<v8::Promise> Session::SetProxy(gin::Arguments* args) {