mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: offscreen mode under window.open creation (#48026)

Browse source 
fix: offscreen mode under `window.open` creation (#47868)

fix: offscreen mode under new window creation

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
Calvin 2025-08-10 13:55:40 -06:00 • committed by GitHub
commit bc56c6987f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 133 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

61
spec/guest-window-manager-spec.ts
View file

@ -4,6 +4,7 @@ import { expect, assert } from 'chai';
import { once } from 'node:events';
import * as http from 'node:http';
import * as nodePath from 'node:path';
import { HexColors, ScreenCapture, hasCapturableScreen } from './lib/screen-helpers';
import { ifit, listen } from './lib/spec-helpers';
@ -203,6 +204,66 @@ describe('webContents.setWindowOpenHandler', () => {
expect(await browserWindow.webContents.executeJavaScript('42')).to.equal(42);
});
it('can open an offscreen child window from an onscreen parent', async () => {
browserWindow.webContents.setWindowOpenHandler(() => ({
action: 'allow',
overrideBrowserWindowOptions: {
webPreferences: {
offscreen: true
}
}
}));
const didCreateWindow = once(browserWindow.webContents, 'did-create-window');
const url = `file://${nodePath.join('fixtures', 'pages', 'content.html')}`;
browserWindow.webContents.executeJavaScript(`window.open('${JSON.stringify(url)}') && true`);
const [childWindow] = await didCreateWindow;
expect(childWindow.webContents.isOffscreen()).to.be.true('Child window should be offscreen');
});
it('can open an onscreen child window from an offscreen parent', async () => {
const obw = new BrowserWindow({
show: false,
webPreferences: {
offscreen: true
}
});
await obw.loadURL('about:blank');
obw.webContents.setWindowOpenHandler(() => ({ action: 'allow' }));
const didCreateWindow = once(obw.webContents, 'did-create-window');
const url = `file://${nodePath.join('fixtures', 'pages', 'content.html')}`;
obw.webContents.executeJavaScript(`window.open('${JSON.stringify(url)}') && true`);
const [childWindow] = await didCreateWindow;
expect(childWindow.webContents.isOffscreen()).to.be.false('Child window should not be offscreen');
});
it('can open an offscreen child window from an offscreen parent', async () => {
const obw = new BrowserWindow({
show: false,
webPreferences: {
offscreen: true
}
});
await obw.loadURL('about:blank');
obw.webContents.setWindowOpenHandler(() => ({
action: 'allow',
overrideBrowserWindowOptions: {
webPreferences: {
offscreen: true
}
}
}));
const didCreateWindow = once(obw.webContents, 'did-create-window');
const url = `file://${nodePath.join('fixtures', 'pages', 'content.html')}`;
obw.webContents.executeJavaScript(`window.open('${JSON.stringify(url)}') && true`);
const [childWindow] = await didCreateWindow;
expect(childWindow.webContents.isOffscreen()).to.be.true('Child window should be offscreen');
});
ifit(hasCapturableScreen())('should not make child window background transparent', async () => {
browserWindow.webContents.setWindowOpenHandler(() => ({ action: 'allow' }));
const didCreateWindow = once(browserWindow.webContents, 'did-create-window');