refactor: bundle the browser and renderer process electron code (#18553)

* refactor: bundle the browser and renderer process electron code

* Bundles browser/init and renderer/init
  * Improves load performance of main process by ~40%
  * Improves load performance of renderer process by ~30%
* Prevents users from importing our "requiring" our internal logic such
as ipc-main-internal.  This makes those message buses safer as they are
less accessible, there is still some more work to be done though to lock
down those buses completely.
* The electron.asar file now only contains 2 files, as a future
improvement maybe we can use atom_natives to ship these two files
embedded in the binary
* This also removes our dependency on browserify which had some strange
edge cases that caused us to have to hack around require-order and
stopped us using certain ES6/7 features we should have been able to use
(async / await in some files in the sandboxed renderer init script)

TLDR: Things are faster and better :)

* fix: I really do not want to talk about it

* chore: add performance improvements from debugging

* fix: resolve the provided path so webpack thinks it is absolute

* chore: fixup per PR review

* fix: use webpacks ProvidePlugin to keep global, process and Buffer alive after deletion from global scope for use in internal code

* fix: bundle worker/init as well to make node-in-workers work

* chore: update wording as per feedback

* chore: make the timers hack work when yarn is not used

lib/renderer/api/exports/electron.js

@@ -6,23 +6,9 @@ const moduleList = require('@electron/internal/renderer/api/module-list')
 // Import common modules.
 common.defineProperties(exports)
 
-for (const {
-  name,
-  file,
-  enabled = true,
-  private: isPrivate = false
-} of moduleList) {
-  if (!enabled) {
-    continue
-  }
-
-  Object.defineProperty(exports, name, {
-    enumerable: !isPrivate,
-    get: common.memoizedGetter(() => {
-      const value = require(`@electron/internal/renderer/api/${file}.js`)
-      // Handle Typescript modules with an "export default X" statement
-      if (value.__esModule) return value.default
-      return value
-    })
+for (const module of moduleList) {
+  Object.defineProperty(exports, module.name, {
+    enumerable: !module.private,
+    get: common.handleESModule(module.loader)
   })
 }

lib/renderer/api/module-list.js

@@ -8,13 +8,15 @@ const enableRemoteModule = v8Util.getHiddenValue(global, 'enableRemoteModule')
 // Renderer side modules, please sort alphabetically.
 // A module is `enabled` if there is no explicit condition defined.
 module.exports = [
-  { name: 'crashReporter', file: 'crash-reporter', enabled: true },
-  {
-    name: 'desktopCapturer',
-    file: 'desktop-capturer',
-    enabled: features.isDesktopCapturerEnabled()
-  },
-  { name: 'ipcRenderer', file: 'ipc-renderer' },
-  { name: 'remote', file: 'remote', enabled: enableRemoteModule },
-  { name: 'webFrame', file: 'web-frame' }
+  { name: 'crashReporter', loader: () => require('./crash-reporter') },
+  { name: 'ipcRenderer', loader: () => require('./ipc-renderer') },
+  { name: 'webFrame', loader: () => require('./web-frame') }
 ]
+
+if (features.isDesktopCapturerEnabled()) {
+  module.exports.push({ name: 'desktopCapturer', loader: () => require('./desktop-capturer') })
+}
+
+if (enableRemoteModule) {
+  module.exports.push({ name: 'remote', loader: () => require('./remote') })
+}

lib/renderer/api/remote.js

@@ -350,7 +350,7 @@ const addBuiltinProperty = (name) => {
 
 const browserModules =
   require('@electron/internal/common/api/module-list').concat(
-    require('@electron/internal/browser/api/module-list'))
+    require('@electron/internal/browser/api/module-keys'))
 
 // And add a helper receiver for each one.
 browserModules