refactor: bundle the browser and renderer process electron code (#18553)

* refactor: bundle the browser and renderer process electron code

* Bundles browser/init and renderer/init
  * Improves load performance of main process by ~40%
  * Improves load performance of renderer process by ~30%
* Prevents users from importing our "requiring" our internal logic such
as ipc-main-internal.  This makes those message buses safer as they are
less accessible, there is still some more work to be done though to lock
down those buses completely.
* The electron.asar file now only contains 2 files, as a future
improvement maybe we can use atom_natives to ship these two files
embedded in the binary
* This also removes our dependency on browserify which had some strange
edge cases that caused us to have to hack around require-order and
stopped us using certain ES6/7 features we should have been able to use
(async / await in some files in the sandboxed renderer init script)

TLDR: Things are faster and better :)

* fix: I really do not want to talk about it

* chore: add performance improvements from debugging

* fix: resolve the provided path so webpack thinks it is absolute

* chore: fixup per PR review

* fix: use webpacks ProvidePlugin to keep global, process and Buffer alive after deletion from global scope for use in internal code

* fix: bundle worker/init as well to make node-in-workers work

* chore: update wording as per feedback

* chore: make the timers hack work when yarn is not used

lib/common/api/exports/electron.js

@@ -2,6 +2,12 @@
 
 const moduleList = require('@electron/internal/common/api/module-list')
 
+exports.handleESModule = (loader) => () => {
+  const value = loader()
+  if (value.__esModule) return value.default
+  return value
+}
+
 exports.memoizedGetter = (getter) => {
   /*
    * It's ok to leak this value as it would be leaked by the global
@@ -24,12 +30,7 @@ exports.defineProperties = function (targetExports) {
   for (const module of moduleList) {
     descriptors[module.name] = {
       enumerable: !module.private,
-      get: exports.memoizedGetter(() => {
-        const value = require(`@electron/internal/common/api/${module.file}.js`)
-        // Handle Typescript modules with an "export default X" statement
-        if (value.__esModule) return value.default
-        return value
-      })
+      get: exports.handleESModule(module.loader)
     }
   }
   return Object.defineProperties(targetExports, descriptors)

lib/common/api/module-list.js

@@ -2,10 +2,10 @@
 
 // Common modules, please sort alphabetically
 module.exports = [
-  { name: 'clipboard', file: 'clipboard' },
-  { name: 'nativeImage', file: 'native-image' },
-  { name: 'shell', file: 'shell' },
+  { name: 'clipboard', loader: () => require('./clipboard') },
+  { name: 'nativeImage', loader: () => require('./native-image') },
+  { name: 'shell', loader: () => require('./shell') },
   // The internal modules, invisible unless you know their names.
-  { name: 'deprecate', file: 'deprecate', private: true },
-  { name: 'isPromise', file: 'is-promise', private: true }
+  { name: 'deprecate', loader: () => require('./deprecate'), private: true },
+  { name: 'isPromise', loader: () => require('./is-promise'), private: true }
 ]

lib/common/reset-search-paths.ts

@@ -5,9 +5,11 @@ const Module = require('module')
 // Clear Node's global search paths.
 Module.globalPaths.length = 0
 
-// Clear current and parent(init.js)'s search paths.
-module.paths = []
-module.parent!.paths = []
+// Clear current bundles search paths.
+const currentNodeModule = Module._cache[__filename]
+if (currentNodeModule) {
+  currentNodeModule.paths = []
+}
 
 // Prevent Node from adding paths outside this app to search paths.
 const resourcesPathWithTrailingSlash = process.resourcesPath + path.sep
@@ -25,19 +27,21 @@ Module._nodeModulePaths = function (from: string) {
   }
 }
 
-const BASE_INTERNAL_PATH = path.resolve(__dirname, '..')
-const INTERNAL_MODULE_PREFIX = '@electron/internal/'
+// Make a fake Electron module that we will insert into the module cache
+const electronModule = new Module('electron', null)
+electronModule.id = 'electron'
+electronModule.loaded = true
+electronModule.filename = 'electron'
+Object.defineProperty(electronModule, 'exports', {
+  get: () => require('electron')
+})
+
+Module._cache['electron'] = electronModule
 
-// Patch Module._resolveFilename to always require the Electron API when
-// require('electron') is done.
-const electronPath = path.join(__dirname, '..', process.type!, 'api', 'exports', 'electron.js')
 const originalResolveFilename = Module._resolveFilename
 Module._resolveFilename = function (request: string, parent: NodeModule, isMain: boolean) {
   if (request === 'electron') {
-    return electronPath
-  } else if (request.startsWith(INTERNAL_MODULE_PREFIX) && request.length > INTERNAL_MODULE_PREFIX.length) {
-    const slicedRequest = request.slice(INTERNAL_MODULE_PREFIX.length)
-    return path.resolve(BASE_INTERNAL_PATH, `${slicedRequest}${slicedRequest.endsWith('.js') ? '' : '.js'}`)
+    return 'electron'
   } else {
     return originalResolveFilename(request, parent, isMain)
   }