refactor: bundle the browser and renderer process electron code (#18553)
* refactor: bundle the browser and renderer process electron code * Bundles browser/init and renderer/init * Improves load performance of main process by ~40% * Improves load performance of renderer process by ~30% * Prevents users from importing our "requiring" our internal logic such as ipc-main-internal. This makes those message buses safer as they are less accessible, there is still some more work to be done though to lock down those buses completely. * The electron.asar file now only contains 2 files, as a future improvement maybe we can use atom_natives to ship these two files embedded in the binary * This also removes our dependency on browserify which had some strange edge cases that caused us to have to hack around require-order and stopped us using certain ES6/7 features we should have been able to use (async / await in some files in the sandboxed renderer init script) TLDR: Things are faster and better :) * fix: I really do not want to talk about it * chore: add performance improvements from debugging * fix: resolve the provided path so webpack thinks it is absolute * chore: fixup per PR review * fix: use webpacks ProvidePlugin to keep global, process and Buffer alive after deletion from global scope for use in internal code * fix: bundle worker/init as well to make node-in-workers work * chore: update wording as per feedback * chore: make the timers hack work when yarn is not used
This commit is contained in:
		
					parent
					
						
							
								a19e55a902
							
						
					
				
			
			
				commit
				
					
						bc527f6b51
					
				
			
		
					 40 changed files with 1612 additions and 920 deletions
				
			
		| 
						 | 
				
			
			@ -10,11 +10,6 @@ common.defineProperties(exports)
 | 
			
		|||
for (const module of moduleList) {
 | 
			
		||||
  Object.defineProperty(exports, module.name, {
 | 
			
		||||
    enumerable: !module.private,
 | 
			
		||||
    get: common.memoizedGetter(() => {
 | 
			
		||||
      const value = require(`@electron/internal/browser/api/${module.file}.js`)
 | 
			
		||||
      // Handle Typescript modules with an "export default X" statement
 | 
			
		||||
      if (value.__esModule) return value.default
 | 
			
		||||
      return value
 | 
			
		||||
    })
 | 
			
		||||
    get: common.handleESModule(module.loader)
 | 
			
		||||
  })
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue