feat: promisify session.clearStorageData() (#17249)

spec/api-session-spec.js

@@ -324,6 +324,26 @@ describe('session module', () => {
   describe('ses.clearStorageData(options)', () => {
     fixtures = path.resolve(__dirname, 'fixtures')
     it('clears localstorage data', (done) => {
+      ipcMain.on('count', (event, count) => {
+        ipcMain.removeAllListeners('count')
+        assert.strictEqual(count, 0)
+        done()
+      })
+      w.webContents.on('did-finish-load', () => {
+        const options = {
+          origin: 'file://',
+          storages: ['localstorage'],
+          quotas: ['persistent']
+        }
+        w.webContents.session.clearStorageData(options).then(() => {
+          w.webContents.send('getcount')
+        })
+      })
+      w.loadFile(path.join(fixtures, 'api', 'localstorage.html'))
+    })
+
+    // TODO(codebytere): remove when promisification is complete
+    it('clears localstorage data (callback)', (done) => {
       ipcMain.on('count', (event, count) => {
         ipcMain.removeAllListeners('count')
         assert.strictEqual(count, 0)

spec/chromium-spec.js

@@ -184,7 +184,7 @@ describe('chromium feature', () => {
             done()
           }).catch((error) => done(error))
         } else {
-          ses.clearStorageData(options, () => {
+          ses.clearStorageData(options).then(() => {
             w.webContents.reload()
           })
         }
@@ -225,7 +225,7 @@ describe('chromium feature', () => {
           assert.strictEqual(message, 'Hello from serviceWorker!')
           session.fromPartition('sw-file-scheme-spec').clearStorageData({
             storages: ['serviceworkers']
-          }, () => done())
+          }).then(() => done())
         }
       })
       w.webContents.on('crashed', () => done(new Error('WebContents crashed.')))
@@ -264,8 +264,8 @@ describe('chromium feature', () => {
           assert.strictEqual(message, 'Hello from serviceWorker!')
           customSession.clearStorageData({
             storages: ['serviceworkers']
-          }, () => {
-            customSession.protocol.uninterceptProtocol('file', (error) => done(error))
+          }).then(() => {
+            customSession.protocol.uninterceptProtocol('file', error => done(error))
           })
         }
       })