mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Bring back build/header_guard cpplint.

Browse source
This commit is contained in:
Cheng Zhao 2014-03-16 08:58:59 +08:00
parent 68cb6ee861
commit bbef33a33a
26 changed files with 90 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

30
script/cpplint.py vendored
View file

@ -7,19 +7,19 @@ import sys
from lib.util import execute
IGNORE_FILES = [
os.path.join('browser', 'atom_application_mac.h'),
os.path.join('browser', 'atom_application_delegate_mac.h'),
os.path.join('browser', 'native_window_mac.h'),
os.path.join('browser', 'resources', 'win', 'resource.h'),
os.path.join('browser', 'ui', 'cocoa', 'event_processing_window.h'),
os.path.join('browser', 'ui', 'cocoa', 'atom_menu_controller.h'),
os.path.join('browser', 'ui', 'cocoa', 'nsalert_synchronous_sheet.h'),
os.path.join('browser', 'ui', 'gtk', 'gtk_custom_menu.cc'),
os.path.join('browser', 'ui', 'gtk', 'gtk_custom_menu_item.cc'),
os.path.join('common', 'api', 'api_messages.cc'),
os.path.join('common', 'api', 'api_messages.h'),
os.path.join('common', 'atom_version.h'),
os.path.join('common', 'swap_or_assign.h'),
os.path.join('atom', 'browser', 'atom_application_mac.h'),
os.path.join('atom', 'browser', 'atom_application_delegate_mac.h'),
os.path.join('atom', 'browser', 'native_window_mac.h'),
os.path.join('atom', 'browser', 'resources', 'win', 'resource.h'),
os.path.join('atom', 'browser', 'ui', 'cocoa', 'event_processing_window.h'),
os.path.join('atom', 'browser', 'ui', 'cocoa', 'atom_menu_controller.h'),
os.path.join('atom', 'browser', 'ui', 'gtk', 'gtk_custom_menu.cc'),
os.path.join('atom', 'browser', 'ui', 'gtk', 'gtk_custom_menu_item.cc'),
os.path.join('atom', 'common', 'api', 'api_messages.cc'),
os.path.join('atom', 'common', 'api', 'api_messages.h'),
os.path.join('atom', 'common', 'api', 'atom_extensions.h'),
os.path.join('atom', 'common', 'atom_version.h'),
os.path.join('atom', 'common', 'swap_or_assign.h'),
]
SOURCE_ROOT = os.path.dirname(os.path.dirname(__file__))
@ -35,7 +35,7 @@ def main():
def list_files(directories, filters):
matches = []
for directory in directories:
for root, _, filenames, in os.walk(directory):
for root, _, filenames, in os.walk(os.path.join('atom', directory)):
for f in filters:
for filename in fnmatch.filter(filenames, f):
matches.append(os.path.join(root, filename))
@ -44,7 +44,7 @@ def list_files(directories, filters):
def call_cpplint(files):
cpplint = os.path.join(SOURCE_ROOT, 'vendor', 'depot_tools', 'cpplint.py')
rules = '--filter=-build/header_guard,-build/include_what_you_use'
rules = '--filter=-build/include_what_you_use'
execute([sys.executable, cpplint, rules] + files)