mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: simplify titlebar overlay initialization (#47480)

Browse source
This commit is contained in:
Charles Kerr 2025-06-23 04:24:05 -05:00 • committed by GitHub
commit bb22eaccec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

20
shell/browser/native_window.cc
View file

@ -114,20 +114,12 @@ NativeWindow::NativeWindow(const gin_helper::Dictionary& options,
options.Get(options::kVibrancyType, &vibrancy_); options.Get(options::kVibrancyType, &vibrancy_);
#endif #endif
v8::Local<v8::Value> titlebar_overlay; if (gin_helper::Dictionary dict;
if (options.Get(options::ktitleBarOverlay, &titlebar_overlay)) { options.Get(options::ktitleBarOverlay, &dict)) {
if (titlebar_overlay->IsBoolean()) { titlebar_overlay_ = true;
options.Get(options::ktitleBarOverlay, &titlebar_overlay_); titlebar_overlay_height_ = dict.ValueOrDefault(options::kOverlayHeight, 0);
} else if (titlebar_overlay->IsObject()) { } else if (bool flag; options.Get(options::ktitleBarOverlay, &flag)) {
titlebar_overlay_ = true; titlebar_overlay_ = flag;
auto titlebar_overlay_dict =
gin_helper::Dictionary::CreateEmpty(options.isolate());
options.Get(options::ktitleBarOverlay, &titlebar_overlay_dict);
int height;
if (titlebar_overlay_dict.Get(options::kOverlayHeight, &height))
titlebar_overlay_height_ = height;
}
} }
WindowList::AddWindow(this); WindowList::AddWindow(this);