mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: use-after-free in ElectronBrowserContext during shutdown (#26680)

Browse source
This commit is contained in:
Jeremy Rose 2020-11-25 12:29:26 -08:00 committed by GitHub
parent 662077f153
commit ba629e3127
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/electron_browser_main_parts.cc
View file

@ -535,7 +535,11 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {
node::Stop(node_env_->env()); node::Stop(node_env_->env());
node_env_.reset(); node_env_.reset();
auto default_context_key = ElectronBrowserContext::PartitionKey("", false);
std::unique_ptr<ElectronBrowserContext> default_context = std::move(
ElectronBrowserContext::browser_context_map()[default_context_key]);
ElectronBrowserContext::browser_context_map().clear(); ElectronBrowserContext::browser_context_map().clear();
default_context.reset();
fake_browser_process_->PostMainMessageLoopRun(); fake_browser_process_->PostMainMessageLoopRun();
content::DevToolsAgentHost::StopRemoteDebuggingPipeHandler(); content::DevToolsAgentHost::StopRemoteDebuggingPipeHandler();