chore: use consistent parameter names (#29361)
This commit is contained in:
parent
d18dbdd72b
commit
ba26580f23
19 changed files with 38 additions and 40 deletions
|
@ -73,17 +73,15 @@ const void* kElectronApiDownloadItemKey = &kElectronApiDownloadItemKey;
|
|||
gin::WrapperInfo DownloadItem::kWrapperInfo = {gin::kEmbedderNativeGin};
|
||||
|
||||
// static
|
||||
DownloadItem* DownloadItem::FromDownloadItem(
|
||||
download::DownloadItem* download_item) {
|
||||
DownloadItem* DownloadItem::FromDownloadItem(download::DownloadItem* item) {
|
||||
// ^- say that 7 times fast in a row
|
||||
auto* data = static_cast<UserDataLink*>(
|
||||
download_item->GetUserData(kElectronApiDownloadItemKey));
|
||||
item->GetUserData(kElectronApiDownloadItemKey));
|
||||
return data ? data->download_item.get() : nullptr;
|
||||
}
|
||||
|
||||
DownloadItem::DownloadItem(v8::Isolate* isolate,
|
||||
download::DownloadItem* download_item)
|
||||
: download_item_(download_item), isolate_(isolate) {
|
||||
DownloadItem::DownloadItem(v8::Isolate* isolate, download::DownloadItem* item)
|
||||
: download_item_(item), isolate_(isolate) {
|
||||
download_item_->AddObserver(this);
|
||||
download_item_->SetUserData(
|
||||
kElectronApiDownloadItemKey,
|
||||
|
@ -118,7 +116,7 @@ void DownloadItem::OnDownloadUpdated(download::DownloadItem* item) {
|
|||
}
|
||||
}
|
||||
|
||||
void DownloadItem::OnDownloadDestroyed(download::DownloadItem* download_item) {
|
||||
void DownloadItem::OnDownloadDestroyed(download::DownloadItem* /*item*/) {
|
||||
download_item_ = nullptr;
|
||||
Unpin();
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue