mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

win: Don't crash on invalid parameter error.

Browse source 
libuv relies on suppressing the invalid parameter error in
uv__get_osfhandle, and it could hanppen frequently.

Fixes #513.
This commit is contained in:
Cheng Zhao 2014-07-26 11:09:01 +08:00
commit b9d64784bb
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/common/crash_reporter/crash_reporter_win.cc
View file

@ -54,12 +54,14 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,
if (waiting_event != INVALID_HANDLE_VALUE) if (waiting_event != INVALID_HANDLE_VALUE)
WaitForSingleObject(waiting_event, 1000); WaitForSingleObject(waiting_event, 1000);
int handler_types = google_breakpad::ExceptionHandler::HANDLER_EXCEPTION |
google_breakpad::ExceptionHandler::HANDLER_PURECALL;
breakpad_.reset(new google_breakpad::ExceptionHandler( breakpad_.reset(new google_breakpad::ExceptionHandler(
temp_dir.value(), temp_dir.value(),
FilterCallback, FilterCallback,
MinidumpCallback, MinidumpCallback,
this, this,
google_breakpad::ExceptionHandler::HANDLER_ALL, handler_types,
kSmallDumpType, kSmallDumpType,
pipe_name.c_str(), pipe_name.c_str(),
GetCustomInfo(product_name, version, company_name))); GetCustomInfo(product_name, version, company_name)));