mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add support for DOM elements going over the context bridge (#26776)

Browse source 
* feat: add support for DOM elements going over the context bridge

* Update context-bridge.md
This commit is contained in:
Samuel Attard 2020-12-10 13:03:00 -08:00 • committed by GitHub
parent 51db2a6b34
commit b9c9e7fc06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 42 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

35
spec-main/api-context-bridge-spec.ts
View file

@ -517,7 +517,7 @@ describe('contextBridge', () => {
expect(result).to.deep.equal([true, true]);
});
it('it should handle recursive objects', async () => {
it('should handle recursive objects', async () => {
await makeBindingWindow(() => {
const o: any = { value: 135 };
o.o = o;
@ -531,6 +531,33 @@ describe('contextBridge', () => {
expect(result).to.deep.equal([135, 135, 135]);
});
it('should handle DOM elements', async () => {
await makeBindingWindow(() => {
contextBridge.exposeInMainWorld('example', {
getElem: () => document.body
});
});
const result = await callWithBindings((root: any) => {
return [root.example.getElem().tagName, root.example.getElem().constructor.name, typeof root.example.getElem().querySelector];
});
expect(result).to.deep.equal(['BODY', 'HTMLBodyElement', 'function']);
});
it('should handle DOM elements going backwards over the bridge', async () => {
await makeBindingWindow(() => {
contextBridge.exposeInMainWorld('example', {
getElemInfo: (fn: Function) => {
const elem = fn();
return [elem.tagName, elem.constructor.name, typeof elem.querySelector];
}
});
});
const result = await callWithBindings((root: any) => {
return root.example.getElemInfo(() => document.body);
});
expect(result).to.deep.equal(['BODY', 'HTMLBodyElement', 'function']);
});
// Can only run tests which use the GCRunner in non-sandboxed environments
if (!useSandbox) {
it('should release the global hold on methods sent across contexts', async () => {
@ -735,7 +762,8 @@ describe('contextBridge', () => {
receiveArguments: (fn: any) => fn({ key: 'value' }),
symbolKeyed: {
[Symbol('foo')]: 123
}
},
getBody: () => document.body
});
});
const result = await callWithBindings(async (root: any) => {
@ -807,7 +835,8 @@ describe('contextBridge', () => {
[(await example.object.getPromise()).arr[3], Array],
[(await example.object.getPromise()).arr[3][0], String],
[arg, Object],
[arg.key, String]
[arg.key, String],
[example.getBody(), HTMLBodyElement]
];
return {
protoMatches: protoChecks.map(([a, Constructor]) => Object.getPrototypeOf(a) === Constructor.prototype)