Disable stack dumping for 32bit ARM

This commit is contained in:
Cheng Zhao 2018-02-06 16:50:58 +09:00
parent 81c23b84e7
commit b9ab2fe0fb

View file

@ -99,6 +99,11 @@ bool AtomMainDelegate::BasicStartupComplete(int* exit_code) {
bool enable_stack_dumping = true; bool enable_stack_dumping = true;
#else #else
bool enable_stack_dumping = env->HasVar("ELECTRON_ENABLE_STACK_DUMPING"); bool enable_stack_dumping = env->HasVar("ELECTRON_ENABLE_STACK_DUMPING");
#endif
#if defined(ARCH_CPU_ARM_FAMILY) && defined(ARCH_CPU_32_BITS)
// For 32bit ARM enabling stack printing would end up crashing.
// https://github.com/electron/electron/pull/11230#issuecomment-363232482
enable_stack_dumping = false;
#endif #endif
if (enable_stack_dumping) if (enable_stack_dumping)
base::debug::EnableInProcessStackDumping(); base::debug::EnableInProcessStackDumping();