mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: remove undocumented feature and flaky test for webview resize event (#36154)

Browse source
This commit is contained in:
Jeremy Rose 2022-10-27 16:44:53 -07:00 • committed by GitHub
parent 67a0c702fa
commit b9464d89b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

30
spec/webview-spec.ts
View file

@ -1957,36 +1957,6 @@ describe('<webview> tag', function () {
['with sandbox', true] as const
]) {
describe(description, () => {
it('emits resize events', async () => {
await loadWebViewAndWaitForEvent(w, {
src: `file://${fixtures}/pages/a.html`,
webpreferences: `sandbox=${sandbox ? 'yes' : 'no'}`
}, 'dom-ready');
const firstResizeSignal = w.executeJavaScript(`new Promise((resolve, reject) => {
webview.addEventListener('resize', (e) => resolve({...e}), {once: true})
})`);
const insertedCSS = await w.insertCSS('webview { width: 100px; height: 10px; }');
const firstResizeEvent = await firstResizeSignal;
expect(firstResizeEvent.newWidth).to.equal(100);
expect(firstResizeEvent.newHeight).to.equal(10);
await w.removeInsertedCSS(insertedCSS);
const secondResizeSignal = w.executeJavaScript(`new Promise((resolve, reject) => {
webview.addEventListener('resize', (e) => resolve({...e}), {once: true})
})`);
const newWidth = 1234;
const newHeight = 789;
await w.insertCSS(`webview { width: ${newWidth}px; height: ${newHeight}px; }`);
const secondResizeEvent = await secondResizeSignal;
expect(secondResizeEvent.newWidth).to.equal(newWidth);
expect(secondResizeEvent.newHeight).to.equal(newHeight);
});
it('emits focus event', async () => {
await loadWebViewAndWaitForEvent(w, {
src: `file://${fixtures}/pages/a.html`,