mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: properly bubble up cookie creation failure message (#37586)

Browse source
This commit is contained in:
Shelley Vohr 2023-03-16 13:48:14 +01:00 • committed by GitHub
parent 48d0b09ad9
commit b8f970c1c7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/api-net-spec.ts
View file

@ -903,6 +903,16 @@ describe('net module', () => {
expect(cookies[0].name).to.equal('cookie2');
});
it('throws when an invalid domain is passed', async () => {
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
await expect(sess.cookies.set({
url: 'https://electronjs.org',
domain: 'wssss.iamabaddomain.fun',
name: 'cookie1'
})).to.eventually.be.rejectedWith(/Failed to set cookie with an invalid domain attribute/);
});
it('should be able correctly filter out cookies that are session', async () => {
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);