test: migrate to helpers & disabled tests list (#37513)

* test: migrate to helpers & disabled tests list

* can't disable a test suite

* correct condition

* address review comments
This commit is contained in:
Calvin 2023-04-04 07:48:51 -06:00 committed by GitHub
parent 58f3c0ee37
commit b8a21dbcd7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 95 additions and 117 deletions

View file

@ -891,8 +891,8 @@ describe('Menu module', function () {
expect(Menu.getApplicationMenu()).to.not.be.null('application menu');
});
// TODO(nornagon): this causes the focus handling tests to fail
it.skip('unsets a menu with null', () => {
// DISABLED-FIXME(nornagon): this causes the focus handling tests to fail
it('unsets a menu with null', () => {
Menu.setApplicationMenu(null);
expect(Menu.getApplicationMenu()).to.be.null('application menu');
});