mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

update mac symbol dump (#12982)

Browse source 
* Update mac symbol dump

Update posix generate_breakpad_symbols.py file to use argparse instead of deprecated optparse.
Also, make changes to the posix generate_breakpad_symbols.py file to accept multiple binaries.
And update dump-symbols.py to get symbols for the mac helper app as well.

* Changes to appease the linter
This commit is contained in:
Nitish Sakhawalkar 2018-05-20 18:01:17 -07:00 • committed by Cheng Zhao
parent 7c19ae302e
commit b842a4b133
2 changed files with 31 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

15
script/dump-symbols.py
View file

@ -22,18 +22,25 @@ def main(destination):
generate_breakpad_symbols = os.path.join(SOURCE_ROOT, 'tools', 'posix',
'generate_breakpad_symbols.py')
if PLATFORM == 'darwin':
start = os.path.join(OUT_DIR, '{0}.app'.format(product_name), 'Contents',
'MacOS', product_name)
#macOS has an additional helper app; provide the path to that binary also
main_app = os.path.join(OUT_DIR, '{0}.app'.format(product_name),
'Contents', 'MacOS', product_name)
helper_name = product_name + " Helper"
helper_app = os.path.join(OUT_DIR, '{0}.app'.format(helper_name),
'Contents', 'MacOS', product_name + " Helper")
binaries = [main_app, helper_app]
else:
start = os.path.join(OUT_DIR, project_name)
binaries = [os.path.join(OUT_DIR, project_name)]
args = [
'--build-dir={0}'.format(OUT_DIR),
'--binary={0}'.format(start),
'--symbols-dir={0}'.format(destination),
'--libchromiumcontent-dir={0}'.format(CHROMIUM_DIR),
'--clear',
'--jobs=16',
]
for binary in binaries:
args += '--binary={0}'.format(binary),
else:
generate_breakpad_symbols = os.path.join(SOURCE_ROOT, 'tools', 'win',
'generate_breakpad_symbols.py')