mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: remove custom Node.js debugger (#25587)

Browse source
This commit is contained in:
Shelley Vohr 2020-09-23 20:35:56 -07:00 • committed by GitHub
parent b980d1bd6b
commit b807cabe1b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 32 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

13
shell/app/node_main.cc
View file

@ -25,7 +25,6 @@
#include "gin/v8_initializer.h"
#include "shell/app/uv_task_runner.h"
#include "shell/browser/javascript_environment.h"
#include "shell/browser/node_debugger.h"
#include "shell/common/api/electron_bindings.h"
#include "shell/common/gin_helper/dictionary.h"
#include "shell/common/node_bindings.h"
@ -202,15 +201,11 @@ int NodeMain(int argc, char* argv[]) {
isolate_data = node::CreateIsolateData(isolate, loop, gin_env.platform());
CHECK_NE(nullptr, isolate_data);
uint64_t flags = node::EnvironmentFlags::kDefaultFlags |
node::EnvironmentFlags::kNoInitializeInspector;
std::vector<std::string> args(argv, argv + argc); // NOLINT
std::vector<std::string> exec_args(exec_argv,
exec_argv + exec_argc); // NOLINT
env = node::CreateEnvironment(isolate_data, gin_env.context(), args,
exec_args,
(node::EnvironmentFlags::Flags)flags);
exec_args);
CHECK_NE(nullptr, env);
node::IsolateSettings is;
@ -247,10 +242,6 @@ int NodeMain(int argc, char* argv[]) {
}
}
// Enable support for v8 inspector.
NodeDebugger node_debugger(env);
node_debugger.Start();
// TODO(codebytere): we should try to handle this upstream.
{
v8::HandleScope scope(isolate);
@ -288,8 +279,6 @@ int NodeMain(int argc, char* argv[]) {
node::performance::NODE_PERFORMANCE_MILESTONE_LOOP_EXIT);
}
node_debugger.Stop();
env->set_trace_sync_io(false);
exit_code = node::EmitExit(env);