mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Hard code the chromedriver's version

Browse source 
It is not possible to run chromedriver for all targets.
This commit is contained in:
Cheng Zhao 2015-07-08 12:32:47 +08:00
parent cb92df687d
commit b7cdb00d09
4 changed files with 10 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
script/upload.py
View file

@ -7,9 +7,9 @@ import subprocess
import sys
import tempfile
from lib.config import PLATFORM, get_target_arch
from lib.config import PLATFORM, get_target_arch, get_chromedriver_version
from lib.util import atom_gyp, execute, get_atom_shell_version, parse_version, \
get_chromedriver_version, scoped_cwd
scoped_cwd
from lib.github import GitHub
@ -83,7 +83,7 @@ def main():
upload_atom_shell(github, release, os.path.join(DIST_DIR, SYMBOLS_NAME))
# Upload chromedriver and mksnapshot for minor version update.
if get_target_arch() != 'arm' and parse_version(args.version)[2] == '0':
if parse_version(args.version)[2] == '0':
chromedriver = 'chromedriver-{0}-{1}-{2}.zip'.format(
get_chromedriver_version(), PLATFORM, get_target_arch())
upload_atom_shell(github, release, os.path.join(DIST_DIR, chromedriver))